[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In D76802#2524039 <https://reviews.llvm.org/D76802#2524039>, @MaskRay wrote:

> - `__llvm_prf_cnts` does not need to have a self link `SHF_LINK_ORDER`. `__llvm_prf_data` linking to `__llvm_prf_cnts` suffices. This is on the premise that only `__llvm_prf_data` may reference `__llvm_prf_cnts`

Discussed with @MaskRay over chat, this is necessary because `__llvm_prf_cnts` is a C identifier.

> - Please update `InstrProfiling/icall.ll` to test `__profvp_` (`-vp-static-alloc=true`). `__llvm_prf_vals` should link to `__llvm_prf_cnts`.

Done.

> - From the current organization of tests, I think `linkage.ll` is a better place than a separate `associated.ll`. The tests there are more comprehensive (needs-comdat and non-needs-comdat cases). You can add the new associated mode to `linkage.ll`.

Done.

> -fbinutils-version is now available. You can condition the associated feature on 2.36 now.

Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76802/new/

https://reviews.llvm.org/D76802