[PATCH] D95508: [X86] Fix tile config register spill issue for AMX
Xiang Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 26 23:39:57 PST 2021
xiangzhangllvm created this revision.
xiangzhangllvm added reviewers: LuoYuanke, pengfei, wxiao3.
Herald added subscribers: hiraditya, qcolombet.
xiangzhangllvm requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
This is an optimized approach for D94155 <https://reviews.llvm.org/D94155> , D95136 <https://reviews.llvm.org/D95136>.
Previous code build the model that tile config register is the user of
each AMX instruction. There is a problem for the tile config register
spill. When across function, the ldtilecfg instruction may be inserted
on each AMX instruction which use tile config register. This cause all
tile data register clobber.
To fix this issue, we remove the model of tile config register. We
analyze the AMX instructions between one call to another. We will insert
ldtilecfg after the first call if we find any AMX instructions.
https://reviews.llvm.org/D95508
Files:
llvm/lib/Target/X86/X86ExpandPseudo.cpp
llvm/lib/Target/X86/X86FrameLowering.cpp
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
llvm/lib/Target/X86/X86InstrAMX.td
llvm/lib/Target/X86/X86InstrInfo.cpp
llvm/lib/Target/X86/X86PreTileConfig.cpp
llvm/lib/Target/X86/X86RegisterInfo.td
llvm/lib/Target/X86/X86TileConfig.cpp
llvm/test/CodeGen/X86/AMX/amx-across-func.ll
llvm/test/CodeGen/X86/AMX/amx-ldtilecfg-insert.ll
llvm/test/CodeGen/X86/AMX/amx-spill-merge.ll
llvm/test/CodeGen/X86/AMX/amx-spill.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95508.319474.patch
Type: text/x-patch
Size: 35879 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210127/85ba8eca/attachment.bin>
More information about the llvm-commits
mailing list