[PATCH] D94882: [MC] Upgrade DWARF version to 5 upon .file 0

Tue Jan 26 23:16:40 PST 2021

MaskRay added a comment.

In D94882#2510560 <https://reviews.llvm.org/D94882#2510560>, @MaskRay wrote:

> In D94882#2509022 <https://reviews.llvm.org/D94882#2509022>, @jhenderson wrote:
>
>> Okay, I'm persuaded by the arguments. I don't really mind whether the tool will ignore an explicitly specified version or not, as long as a warning is emitted if it does ignore it. I think we want to avoid the potential confusion of "I asked for DWARFv3, but am getting DWARFv5 output", and a warning would at least help with that (assuming of course we don't just refuse to handle this case, which I think is also an acceptable, and possibly preferable solution).
>
> GNU as hasn't implemented the diagnostic yet.
>
> Implementing the warning in MC needs a new option (`clang -c a.c` passes `-dwarf-version` to cc1as even in the absence of -g).

Opinions? :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94882/new/

https://reviews.llvm.org/D94882