[PATCH] D95480: [NFC] Fix bug with parsing hybrid sample trace line

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:413
+      // skip it
       TraceIt.advance();
+      return false;
----------------
line 413 and line 416 can be hoisted to line 409?


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:414
       TraceIt.advance();
-      break;
+      return false;
     }
----------------
This change means we no longer handle a comment line mixed in stack sample? Although I'm not sure if we ever need a comment line.. 




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95480/new/

https://reviews.llvm.org/D95480