[PATCH] D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 22:21:01 PST 2021


xur added a comment.

I think the patch is going the right direction.  Some minor comments:
(1) If we have two entries with the same value (other than 0), will we have the same issue? I think we will have same invalid switch statement. So can we extend this patch to handle this? That should be a small change.
(2) can we change "invalid merge" to "invalid profile"? This does not look like a merge issue -- at least from the test case where the problem is from the raw profile. This points to profile runtime issue. I think invalid profile is more appropriate here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92074/new/

https://reviews.llvm.org/D92074



More information about the llvm-commits mailing list