[PATCH] D95029: [CSKY 6/n] Add support branch and symbol series instruction

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/Target/CSKY/AsmParser/CSKYAsmParser.cpp:185
+      return false;
+    return true;
+  }
----------------
can you condense these three lines into a single return statement?


================
Comment at: llvm/lib/Target/CSKY/AsmParser/CSKYAsmParser.cpp:193
+      return false;
+    return true;
+  }
----------------
ditto


================
Comment at: llvm/lib/Target/CSKY/AsmParser/CSKYAsmParser.cpp:379
+        Operands, ErrorInfo, -(1 << 15), (1 << 15) - 2,
+        "immediate must be a multiple of 2 bytes in the range");*/
+  case Match_InvalidCSKYSymbol: {
----------------
please remove unused comment. Or add FIXME/TODO with explanations 


================
Comment at: llvm/lib/Target/CSKY/AsmParser/CSKYAsmParser.cpp:551
+  SMLoc E = SMLoc::getFromPointer(S.getPointer() - 1);
+  const MCExpr *Res;
+
----------------
can you combine this declaration with line 572? I didn't see any reference of Res until line 572


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95029/new/

https://reviews.llvm.org/D95029