[PATCH] D95495: Emit metadata if there is a profile hash mismatch

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 21:28:17 PST 2021


davidxl added inline comments.


================
Comment at: llvm/test/Transforms/PGOProfile/hash_mismatch_metadata.ll:2
+; RUN: llvm-profdata merge %S/Inputs/hash_mismatch_metadata.proftext -o %t.profdata
+; RUN: opt < %s -mtriple=x86_64-linux-gnu -passes=pgo-instr-use -pgo-test-profile-file=%t.profdata -S | FileCheck %s
+
----------------
snehasish wrote:
> Would it be useful to add a test to check that existing metadata is preserved?
That  (end-to-end) can be added as a profile runtime test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95495/new/

https://reviews.llvm.org/D95495



More information about the llvm-commits mailing list