[PATCH] D95495: Emit metadata if there is a profile hash mismatch

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1254
+  if (F.getMetadata(LLVMContext::MD_annotation))
+    return;
+
----------------
davidxl wrote:
> Do you need to check the string as well?
Thanks. I was debating what to do here, I had it as checking the string first.  However, I noticed function metadata with annotation is only added here so I was not sure.  Let me change it to explicitly check the string.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95495/new/

https://reviews.llvm.org/D95495