[PATCH] D95480: [NFC] Fix bug with parsing hybrid sample trace line

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 16:47:47 PST 2021


hoy accepted this revision.
hoy added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for the fix!



================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:453
   // missing.
-  return !Binary->addressInPrologEpilog(CallStack.front());
+  return !CallStack.empty() &&
+         !Binary->addressInPrologEpilog(CallStack.front());
----------------
Nit: comment may be updated to reflect the truncated callstack case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95480/new/

https://reviews.llvm.org/D95480



More information about the llvm-commits mailing list