aprantl added a comment. I think this looks mostly good, but it looks like it's missing a unittest for the DIBuilder function that you added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76115/new/ https://reviews.llvm.org/D76115