[PATCH] D95452: [LoopVectorize] use IR fast-math-flags exclusively (not function attributes)
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 26 13:34:34 PST 2021
dmgreen added a comment.
Should InductionDescriptor::hasUnsafeAlgebra be using isFast, or can it be something more precise? Just reassoc or does it need NoNan for some reason? Any others like NoInf?
I don't have a strong reason to think that is necessary though. This sounds fine to me as most of it is an NFC, with the only difference being the FP induction change. Removing NoNaN from VPReductionRecipe is nice now that they can come from the RecurrenceDesc.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95452/new/
https://reviews.llvm.org/D95452
More information about the llvm-commits
mailing list