[PATCH] D95328: [flang][openacc][NFC] Organize clause validity tests by directive

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 11:52:29 PST 2021


clementval added a comment.

In D95328#2522642 <https://reviews.llvm.org/D95328#2522642>, @SouraVX wrote:

> Thanks! LGTM! Same approach I followed in `openmp` work, keeping test cases short and dedicated for instance (a directive and all it's assoicated clauses). It pays off in diagnosing/modifying when some test case fails(due to 2 branch development).

Thanks for the review. Right it was getting too big to maintain it correctly and also lit can parallelize tests so more small tests are better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95328/new/

https://reviews.llvm.org/D95328



More information about the llvm-commits mailing list