[PATCH] D95216: [AMDGPU][MC] Refactored exp tgt handling

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 10:17:45 PST 2021


MaskRay added a comment.

In D95216#2523107 <https://reviews.llvm.org/D95216#2523107>, @dp wrote:

> In D95216#2523007 <https://reviews.llvm.org/D95216#2523007>, @MaskRay wrote:
>
>> In your commit the message has just `Reviewers:`.
>
> "git log" seems to display the list of reviewers correctly:
>
>   Reviewers: arsenm, rampitec, foad
>
> When I open this commit on github, the reviewer list seems to be present as well:
> https://github.com/llvm/llvm-project/commit/745064e36b8751548061cc72039dc039c566d175
>
> What am I missing?

`arc diff` created message does not have `Reviewers:`. `arc amend` can drop the tag as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95216/new/

https://reviews.llvm.org/D95216



More information about the llvm-commits mailing list