[PATCH] D93497: Salvage debug info for function arguments in coro-split funclets.
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 26 10:12:51 PST 2021
aprantl added a comment.
In D93497#2522122 <https://reviews.llvm.org/D93497#2522122>, @bruno wrote:
> Hi Adrian, this is nice, I really like the approach! Do you think that this supersedes https://reviews.llvm.org/D90772? I'm curious if we can stop generating the extra `dbg.values` inserted, or whether those are necessary for your reconstruction work?
Yes, after this patch, we should be able to revert D90772 <https://reviews.llvm.org/D90772> without loosing any functionality. This patch inserts dbg.declare intrinsics into the coro-split funclets which are by definition valid throughout the entire function, so any dbg.value intrinsics describing the same variables would be redundant.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93497/new/
https://reviews.llvm.org/D93497
More information about the llvm-commits
mailing list