[PATCH] D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 09:34:17 PST 2021


paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4460
+  unsigned OpO, OpE;
+  switch (MI.getOpcode()) {
+  case TargetOpcode::G_ADD:
----------------
Since there are only two cases, an `if`/`else` is sufficient here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95426/new/

https://reviews.llvm.org/D95426



More information about the llvm-commits mailing list