[PATCH] D95125: [WebAssembly] Enable loop unrolling

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

> Are you thinking of machine code size? That matters too, but the bigger concern is wasm binary size, which is what is downloaded. Doing unrolling after the download is better for that.

Yep, I was thinking about the transformed/unrolled wasm, or the machine code, that has to be the same similar. But yes, agreed of course that the input, the downloaded wasm, will be bigger compared to unrolling by the producer.

Thanks for clarifying and elaborating on this. It wasn't clear to me from previous comments what exactly was meant with "regressing code-size", and that it is not only about the code-size/perf ratio (the 10% code for 10% speed) and whether that is good enough, but also that it is about the download size. That's clear now.

I will now leave the rest of this discussion to the wasm professionals. :-) Cheers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95125/new/

https://reviews.llvm.org/D95125