[PATCH] D95273: AMDGPU: Reduce the number of expensive calls in SIFormMemoryClause

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 09:14:10 PST 2021


MaskRay added a comment.

In your commit the message has just `Reviewers:`. The `Reviewers:` list does not necessarily mean all the people on the list have acknowledged the patch so `Reviewers:` is mostly useless. Many people agree that both `Reviewed by:` & `Differential Revision:` should be present.

`arc amend` can fetch the Phabricator summary and amend the local description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95273/new/

https://reviews.llvm.org/D95273



More information about the llvm-commits mailing list