[PATCH] D95304: [update_llc_test_checks][RISCV] Add new tests

Tue Jan 26 07:32:32 PST 2021

jrtc27 added a comment.

In D95304#2522758 <https://reviews.llvm.org/D95304#2522758>, @luismarques wrote:

> In D95304#2522347 <https://reviews.llvm.org/D95304#2522347>, @jrtc27 wrote:
>
>> That's... not a good way to fix a bug? This is news to me, and that was committed without any review (let alone by RISC-V maintainers...). And no mention of what the bug actually is in the commit message.
>
> Indeed.
>
> In D95304#2522342 <https://reviews.llvm.org/D95304#2522342>, @jrtc27 wrote:
>
>> Hm, there is a lot of duplication in all these tests (we currently have 12 copies of almost-identical IR), it seems like we should just add a whole load of CHECK lines to a single copy of the IR?..
>
> That would be nice if possible, but IMO that should be a separate patch. Wouldn't that require the bots to support all of the targets to run the combined test? I also wonder if that could become awkward in the future if the outlining started to diverge significantly between targets.

Ah good point, you'd want the single copy of the IR and prepend a header on the thing at test time for each architecture (each being its own .test like now)? I.e. we'd just generate all the foo_generated_funcs.ll at test time rather than have N copies of them in the tree, but everything else would be the same.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95304/new/

https://reviews.llvm.org/D95304