[PATCH] D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 06:45:01 PST 2021


StephenTozer added a comment.

In D95045#2522531 <https://reviews.llvm.org/D95045#2522531>, @TWeaver wrote:

> I would argue this is minor enough to go in without one, but I'm happy to add one if you feel strongly in favour for a test going in too.

I'm not especially concerned about it, it does seem like it might be needless bloat - if anyone else disagrees however I'm not opposed to the adding of a test either, especially if there aren't many unit tests around here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95045/new/

https://reviews.llvm.org/D95045



More information about the llvm-commits mailing list