[PATCH] D95220: [flang][driver] Report prescanning diags during syntax-only parsing

Tue Jan 26 05:42:34 PST 2021

awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

Thank you for working on this @FarisRehman ! LGTM

================
Comment at: flang/test/Frontend/prescanner-diag.f90:3
+
+! Preprocessor action
+! RUN: %f18 -E -I %S/Inputs/ %s 2>&1 | FileCheck %s
----------------
[nit] Currently there's only one "preprocessor" action, but there are likely to be more in the future. So this might become ambiguous.

I suggest either `PrintPreprocessedAction` or `Test with -E (i.e. PrintPreprocessedAction, stops after prescanning)` and `Test with -fsyntax-only (i.e. ParseSyntaxOnlyAction, stops after semantic checks)`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95220/new/

https://reviews.llvm.org/D95220