[PATCH] D95373: Replace vector intrinsics with call to vector library

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 05:34:30 PST 2021


fhahn added a comment.

In D95373#2522603 <https://reviews.llvm.org/D95373#2522603>, @spatel wrote:

> I haven't looked at the trade-offs, but if we can do this transform later ( SelectionDAGLegalize::ConvertNodeToLibcall() ? ) that would seem to be more flexible...and smaller patch? 
> For reference:
> D8131 <https://reviews.llvm.org/D8131> - added support for external vector library calls
> D70107 <https://reviews.llvm.org/D70107> - added inject-tli-mappings

+1 on doing this as late as possible. Ideally we would then just get rid of the logic in LV/SLP that inserts the library calls.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95373/new/

https://reviews.llvm.org/D95373



More information about the llvm-commits mailing list