[PATCH] D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method

Tom Weaver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 04:17:07 PST 2021


TWeaver updated this revision to Diff 319267.
TWeaver added a comment.

Added more context to diff


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95045/new/

https://reviews.llvm.org/D95045

Files:
  debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py


Index: debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
===================================================================
--- debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
+++ debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
@@ -121,7 +121,9 @@
     def _delete_conditional_breakpoint(self, file_, line, condition):
         for bp in self._debugger.Breakpoints:
             for bound_bp in bp.Children:
-                if (bound_bp.File == file_ and bound_bp.FileLine == line and
+                file = os.path.normcase(file_)
+                bound_bp_file = os.path.normcase(bound_bp.File)
+                if (bound_bp_file == file and bound_bp.FileLine == line and
                     bound_bp.Condition == condition):
                     bp.Delete()
                     break


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95045.319267.patch
Type: text/x-patch
Size: 841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210126/4d9a7672/attachment.bin>


More information about the llvm-commits mailing list