[PATCH] D95304: [update_llc_test_checks][RISCV] Add new tests

Tue Jan 26 01:58:57 PST 2021

jrtc27 added a comment.

In D95304#2522341 <https://reviews.llvm.org/D95304#2522341>, @arichardson wrote:

> This used to exist but it exposed a bug and the test was removed in b8779337841bea03bc514d239ce76eceba3f01dd <https://reviews.llvm.org/rGb8779337841bea03bc514d239ce76eceba3f01dd>.  The commit message states that it only happened with expensive-checks. If it works (with expensive checks) b8779337841bea03bc514d239ce76eceba3f01dd <https://reviews.llvm.org/rGb8779337841bea03bc514d239ce76eceba3f01dd> can be reverted.

That's... not a good way to fix a bug? This is news to me, and that was committed without any review (let alone by RISC-V maintainers...). And no mention of what the bug actually is in the commit message.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95304/new/

https://reviews.llvm.org/D95304