[PATCH] D94912: [llvm-nm][ELF] - Use @@ prefix when printing default versions.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 01:16:57 PST 2021


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1691
+struct SymbolVersion {
+  std::string Name;
+  bool IsDefault;
----------------
MaskRay wrote:
> StringRef can be used.
No, because this string comes from

```
  Expected<SmallVector<Optional<VersionEntry>, 0>> MapOrErr =
      Obj.loadVersionMap(SymVerNeedSec, SymVerDefSec);
```

which internally builds a string.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94912/new/

https://reviews.llvm.org/D94912



More information about the llvm-commits mailing list