[PATCH] D95414: [FaultsMaps][llvm-objdump] Move FaultMapParser to Object/. Remove CodeGen dependency from llvm-objdump

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

Have you made sure the includes in both the files being moved from and being moved to are minimal? Seems like an easy thing to forget to do, but I have no specific example of any that are incorrect (I haven't gone digging). LGTM, aside from that and the inline comments.



================
Comment at: llvm/lib/Object/FaultMapParser.cpp:45
+     << ", NumFaultingPCs: " << FI.getNumFaultingPCs() << "\n";
+  for (unsigned i = 0, e = FI.getNumFaultingPCs(); i != e; ++i)
+    OS << FI.getFunctionFaultInfoAt(i) << "\n";
----------------
Consider fixing these clang-tidy warnings whilst you're moving the code.


================
Comment at: llvm/lib/Object/FaultMapParser.cpp:59
+
+  for (unsigned i = 0, e = FMP.getNumFunctions(); i != e; ++i) {
+    FI = (i == 0) ? FMP.getFirstFunctionInfo() : FI.getNextFunctionInfo();
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95414/new/

https://reviews.llvm.org/D95414