[PATCH] D94740: [Attributor] Create `AAMustProgress` for the `mustprogress` attribute

Hideto Ueno via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 01:11:56 PST 2021


uenoku added a comment.
Herald added a reviewer: bollu.

Basically it looks good to me.
However, it's not obvious to me that (known) `willreturn` can derive `mustprogress`.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2363-2367
+    Function *F = getAnchorScope();
+    if (!F)
+      indicatePessimisticFixpoint();
+    else if (F->mustProgress())
+      indicateOptimisticFixpoint();
----------------
This initialization is already done by `AAMustProgress::initialize(A)` so I think `initialize` function can be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94740/new/

https://reviews.llvm.org/D94740



More information about the llvm-commits mailing list