[PATCH] D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 09:04:34 PST 2021


probinson added a comment.

In D82363#2506919 <https://reviews.llvm.org/D82363#2506919>, @StephenTozer wrote:

> W.r.t the replacement of `DBG_VALUE` with `DBG_VALUE_LIST`, the current plan is to make that all happen in a patch following this stack. The patch itself should mostly be deletion of old code and simplifying where possible, renaming `DBG_VALUE_LIST` to `DBG_VALUE`, adding an extra operand to the new `DBG_VALUE` to represent directness, adding several tests, and updating existing tests as appropriate.

IMO if that part could be done in stages without excessive churn, that would be best.  In particular the new operand for directness seems like its own thing?  The rest of it would seem fairly mechanical/NFC, although admittedly I haven't been following this closely.  (So, pay more attention to the real reviewers, if they have a different opinion.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82363/new/

https://reviews.llvm.org/D82363



More information about the llvm-commits mailing list