[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

Mon Jan 25 23:25:07 PST 2021

phosek added a comment.

In D76802#2520731 <https://reviews.llvm.org/D76802#2520731>, @MaskRay wrote:

> It might cause friction to PGO+non-LLD users... I think it might be premature for LLVM 13.0.0. 14.0.0 may be fine.

Do you think we should go with the current solution then and change the default to enable `-counter-associated-metadata` in LLVM 14.0.0?

> You may add tests to `linkage.ll`  (see D84723 <https://reviews.llvm.org/D84723>).
>
> With the current path, `opt -counter-associated-metadata=1 < linkage.ll -mtriple=x86_64-unknown-linux -instrprof -S | llc -filetype=obj` crashes due to an empty metadata node.

I forgot to upload the latest patch which uses `sh_link=self` instead of `sh_link=0`, it should be working now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76802/new/

https://reviews.llvm.org/D76802