[PATCH] D95420: Revert "[WebAssembly] MC layer writes table symbols to object files"

[Sam Clegg via Phabricator via llvm-commits]

sbc100 created this revision.
Herald added subscribers: wingo, ecnelises, arphaman, sunfish, hiraditya, jgravelle-google, dschuff.
sbc100 requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

This reverts commit d806618636f8a82bfc3f620e1fad83af4d2a2575 <https://reviews.llvm.org/rGd806618636f8a82bfc3f620e1fad83af4d2a2575>.
Review: https://reviews.llvm.org/D92215

We had issues where older version of wasm-ld were crashing if object
files contains this new symbol type.  Even if they correctly report the
unknown symbol type they still can't handle the object as input.  We
decided that the best stratagy here is to only generate these symbol
types if refernece types is enabled.  Without reference types enabled we
should never geneate a table symbol or a TABLE_NUMBER relocation.

This revert is in addition to the one already reverted in
https://reviews.llvm.org/D95005.

The plan is to re-land these in updated form after the llvm 12 branch
point.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95420

Files:
  llvm/lib/MC/WasmObjectWriter.cpp
  llvm/test/MC/WebAssembly/debug-info.ll
  llvm/test/MC/WebAssembly/debug-info64.ll
  llvm/test/MC/WebAssembly/function-alias.ll
  llvm/test/MC/WebAssembly/global-ctor-dtor.ll
  llvm/test/MC/WebAssembly/reloc-pic.s
  llvm/test/MC/WebAssembly/type-index.s
  llvm/test/MC/WebAssembly/weak-alias.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95420.319209.patch
Type: text/x-patch
Size: 9222 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210126/3a331db3/attachment.bin>