[PATCH] D95414: [FaultsMaps][llvm-objdump] Move FaultMapParser to Object/. Remove CodeGen dependency from llvm-objdump

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Object/FaultMapParser.h:13
 
-  struct FaultInfo {
-    FaultKind Kind = FaultKindMax;
-    const MCExpr *FaultingOffsetExpr = nullptr;
-    const MCExpr *HandlerOffsetExpr = nullptr;
+#ifndef LLVM_OBJECT_FAULTMAPPARSER_H
+#define LLVM_OBJECT_FAULTMAPPARSER_H
----------------
`clang-tidy: warning: code/includes outside of area guarded by header guard; consider moving it [llvm-header-guard]`

Move the guard before other includes.


================
Comment at: llvm/include/llvm/Object/FaultMapParser.h:156
 raw_ostream &
 operator<<(raw_ostream &OS, const FaultMapParser::FunctionFaultInfoAccessor &);
 
----------------
Consider reformat it while you are moving code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95414/new/

https://reviews.llvm.org/D95414