[PATCH] D95414: [FaultsMaps][llvm-objdump] Move FaultMapParser to Object/. Remove CodeGen dependency from llvm-objdump

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 19:00:55 PST 2021


craig.topper created this revision.
craig.topper added reviewers: MaskRay, sanjoy.
Herald added subscribers: rupprecht, hiraditya, mgorny.
Herald added a reviewer: jhenderson.
craig.topper requested review of this revision.
Herald added a project: LLVM.

FaultsMapParser lived in CodeGen and was forcing llvm-objdump to
link CodeGen and everything CodeGen depends on.

This was previously attempted in r240364 to fix a link failure.
The CodeGen dependency was independently added to fix the same
link failure, and that ended up being kept.

Removing the dependency seems like the correct layering for
llvm-objdump.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95414

Files:
  llvm/include/llvm/CodeGen/FaultMaps.h
  llvm/include/llvm/Object/FaultMapParser.h
  llvm/lib/CodeGen/FaultMaps.cpp
  llvm/lib/Object/CMakeLists.txt
  llvm/lib/Object/FaultMapParser.cpp
  llvm/tools/llvm-objdump/CMakeLists.txt
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95414.319189.patch
Type: text/x-patch
Size: 14230 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210126/d33daf7a/attachment.bin>


More information about the llvm-commits mailing list