[PATCH] D95399: [flang][fir] Upstream FIR dialect changes.

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added inline comments.


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRDialect.h:49
+  explicit FIRCodeGenDialect(mlir::MLIRContext *ctx);
+  virtual ~FIRCodeGenDialect();
+
----------------
mehdi_amini wrote:
> I don't find a definition for these methods right now?
See https://reviews.llvm.org/D95401


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRDialect.h:68
   // clang-format on
+  registry.loadAll(&ctx);
 }
----------------
mehdi_amini wrote:
> Why is this needed? In general this indicates a misconfiguration of the pipeline and shouldn't be used.
> 
> (also this method is not used in this patch)
The test tools call this to register the dialects they'll use. If there is some preferred way of forcing that to happen, can you provide a pointer? Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95399/new/

https://reviews.llvm.org/D95399