[PATCH] D95377: [AMDGPU] Avoid mentioning GFX10 unnecessarily in docs

[Tony Tye via Phabricator via llvm-commits]

t-tye requested changes to this revision.
t-tye added a comment.
This revision now requires changes to proceed.

A concern I have is that we do not know if future hardware will match what previous hardware is doing. By explicitly stating the range of targets it is clear that the document is saying nothing about future hardware. For example, do you know that future hardware will have the same layout for compute_pgm_rsrc3 register? Or the memory model will be the same? If new hardware comes along I think it is better to simply search for the gfx10 and decide what to do. That seems less error prone than searching for '+'.



================
Comment at: llvm/docs/AMDGPUUsage.rst:4105
   .. table:: compute_pgm_rsrc3 for GFX10
-     :name: amdgpu-amdhsa-compute_pgm_rsrc3-gfx10-table
+     :name: amdgpu-amdhsa-compute_pgm_rsrc3-table
 
----------------
The title says GFX10 so the label should also have gfx10 in the name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95377/new/

https://reviews.llvm.org/D95377