[PATCH] D95289: [TargetLowering][RISCV] Don't turn (seteq/ne (sext_inreg X, VT), C1) -> (seteq/ne (zext_inreg X, VT), C1) if the sext_inreg is cheaper

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 14:03:10 PST 2021


luismarques added a comment.

In D95289#2521120 <https://reviews.llvm.org/D95289#2521120>, @craig.topper wrote:

> I omitted that clang-format change from my patch because its not really in code I touched. Does clang-format widen its scope to include an else if that I that follows the one I changed?

Oh yeah, nevermind. I had seen your comment (in another review) about your local clang-format giving different results than the clang-format in CI and I jumped the gun when I saw this lint check, assuming it had happened again. I don't know how loose git-clang-format is about formatting only the lines you actually changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95289/new/

https://reviews.llvm.org/D95289



More information about the llvm-commits mailing list