[PATCH] D95288: [ValueTracking] Don't assume readonly function will return

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 12:35:57 PST 2021


SjoerdMeijer added a comment.

In D95288#2520069 <https://reviews.llvm.org/D95288#2520069>, @jdoerfert wrote:

>> Yeah, I agree that mustprogress, argmemonly and nosync should imply willreturn. However, FuncAttrs currently infers neither nosync nor argmemonly, so it would need those first. I think that the argmemonly check here was there to cover some common intrinsics like llvm.memcpy, but those are explicitly willreturn now.
>
> Post release branch we should start running a light Attributor, to get things like nosync, argmemonly, ... one by one.

But just for my understanding, does this mean there’s a problem that we intend to fix after the release?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95288/new/

https://reviews.llvm.org/D95288



More information about the llvm-commits mailing list