[PATCH] D94766: Add lit env variable to disable indirect checks

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 12:04:02 PST 2021


yln added a comment.

>>> Actually, it seems to me that `--no-indirect-run-check` probably should have been a lit config option in the first place.  It declares a property of the test suite: it has legitimate tests that are only run individually.  lit invocations shouldn't have to declare that again and again.  Or have I misunderstood the use case?
>>
>> No that makes sense. A config option would work for me. Should I make a new patch to that effect then?
>
> Ignoring backward-compatibility, would the command-line option then be unnecessary?  Whether we remove it immediately is a different question.
>
> Before you invest time in this, it might be good to hear from someone else.  @yln, does this solution seem reasonable to you?

Sounds good to me, thanks! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94766/new/

https://reviews.llvm.org/D94766



More information about the llvm-commits mailing list