[PATCH] D92284: [VPlan] Manage induction value creation using VPValues.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8319
+
+  if (hasScalarValue(Def, {Part, 0})) {
+    Value *ScalarValue = get(Def, {Part, 0});
----------------
fhahn wrote:
> gilr wrote:
> > - Make this an early exit?
> > - Worth leaving a TODO for replacing the IF with an assertion once all scalar recipes are VPDef'ed and throwing away that callback.
> The early exit is much better & I also added a TODO. thanks!
I put up a patch to remove the `getOrCreateVectorValues` call and the whole `VPCallback`: D95383 :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92284/new/

https://reviews.llvm.org/D92284