[PATCH] D95302: [RISCV] Remove isel patterns for Zbs *W instructions.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D95302#2519408 <https://reviews.llvm.org/D95302#2519408>, @simoncook wrote:

> Is there value in still having most of these tests without the pattern? Some of these now look like tests just of `andn`, and in others now that enabling `b` or `zbs` has no effect on code generation. I wonder if this change should instead just completely remove the edited tests. If future additions make them relevant again they could later be readded.

I think all of these tests also exist in rv32Zbs.ll without the signext attributes. So there is some value for the comparison between rv32 and rv64. I might start looking at optimizing some of these soon though we're likely to need 3 instructions to use the non-W instructions so I'm not sure its worth optimizing all of them.

I put this patch up now because I thought it might make sense to not having llvm 12 emitting instructions we knew were going away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95302/new/

https://reviews.llvm.org/D95302