[PATCH] D95303: [RISCV] Implement vlsegff intrinsics.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

LGTM with that comment.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1431
+                                 /*Glue*/ Load.getValue(NF + 1));
+    SmallVector<SDValue, 8> LoadValues;
+    for (unsigned i = 0; i < NF; ++i)
----------------
Since this contains ReadVL result and the chain, something like "Results" would be a better name.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1475
+                                 /*Glue*/ Load.getValue(NF + 1));
+    SmallVector<SDValue, 8> LoadValues;
+    for (unsigned i = 0; i < NF; ++i)
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95303/new/

https://reviews.llvm.org/D95303