[PATCH] D95322: [RISCV] Custom type legalize i8/i16 UDIV/UREM/SDIV on RV64 so we can use divuw/remuw/divw.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 09:45:15 PST 2021


craig.topper added a comment.

In D95322#2519185 <https://reviews.llvm.org/D95322#2519185>, @frasercrmck wrote:

> LGTM, though I'd prefer the linter's suggestion over that manually-formatted code. You might be able to improve it somewhat with choice use of parens?

Weirdly that came from clang-format. I just rebuilt it and double checked. Not sure if that means phabricator is using an older version of clang-format?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95322/new/

https://reviews.llvm.org/D95322



More information about the llvm-commits mailing list