[PATCH] D95125: [WebAssembly] Enable loop unrolling

[Alon Zakai via Phabricator via llvm-commits]

kripken added a comment.

In D95125#2519248 <https://reviews.llvm.org/D95125#2519248>, @samparker wrote:

> The unrolling would be disabled at -Os and -Oz, see
>
> AFAIK, loop unrolling is disabled at -O1 for all targets. I don't think there's currently a backend mechanism to make a decision on the opt level, but the loop unroller uses them to adjust thresholds to be more aggressive in some situations.

I see, thanks samparker.

What concerns me is that some existing users will definitely be harmed by this, if the default for -O2 changes. That's the default in many build systems, so we will be getting bug reports on "why is my code larger", I bet.

With that said, if I am the only holdout, then I won't stand in the way. But if we do this I'd recommend we at least update changelogs and docs in preparation, to try to minimize the annoyance for users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95125/new/

https://reviews.llvm.org/D95125