[PATCH] D95321: [NFC] Fixing build warning with llvm-mca

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

In D95321#2519369 <https://reviews.llvm.org/D95321#2519369>, @lebedev.ri wrote:

> In D95321#2519352 <https://reviews.llvm.org/D95321#2519352>, @andreadb wrote:
>
>> LGTM.
>>
>> For the record, that warning was firstly introduced by another commit which was meant to be an NFC refactoring
>> in preparation for the most recent work that added support for the generation of JSON files.
>>
>> commit cf6adecd6a8718ee2737ca55e4cd938364b984cc <https://reviews.llvm.org/rGcf6adecd6a8718ee2737ca55e4cd938364b984cc>
>
> Citation needed.
> Even the warning says otherwise.

Right. I completely misunderstood that warning.
I wrongly thought that somehow llvm::zip was introducing copies under the hood. But as you wrote, that is not what the warning is saying and zip doesn't work that way.
Sorry about the confusion. You are absolutely right and the patch still looks good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95321/new/

https://reviews.llvm.org/D95321