[PATCH] D88391: [M68k] (Patch 5/8) Target lowering
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 25 03:47:43 PST 2021
RKSimon added inline comments.
================
Comment at: llvm/lib/Target/M68k/M68kMCInstLower.cpp:119
+ LLVM_DEBUG(MI->dump());
+ llvm_unreachable("unknown operand type");
+ case MachineOperand::MO_Register:
----------------
myhsu wrote:
> RKSimon wrote:
> > (style) Move this after the switch statement
> GCC 9 popped out warnings about unhandled cases after moving llvm_unreachable after the switch statement
OK - leave it as is.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88391/new/
https://reviews.llvm.org/D88391
More information about the llvm-commits
mailing list