[PATCH] D94088: [SCEV] Assumption context for GetMinTrailingZeros

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

I would expect that the SCEV change could be testable with just the scev itselfs (`-analyze -scalar-evolution`), is it not?



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:5611-5615
+  if (!CxtI) {
+    auto I = MinTrailingZerosCache.find(S);
+    if (I != MinTrailingZerosCache.end())
+      return I->second;
+  }
----------------
Doesn't this defy the point of the cache?
I think `MinTrailingZerosCache`'s key should be changed to be a `std::pair<SCEV*,CxtI*>`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94088/new/

https://reviews.llvm.org/D94088