[PATCH] D95158: Use DataExtractor to decode SLEB128 in android_relas.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 25 01:23:47 PST 2021
grimar added a comment.
A minor nit from me, the rest looks fine.
================
Comment at: llvm/lib/Object/ELF.cpp:431
+ if (!Cur)
+ return std::move(Cur.takeError());
}
----------------
Looks like you can remove these 2 lines and do the following?
```
for (uint64_t I = 0; Cur && I != NumRelocsInGroup; ++I) {
```
It is a bit shorter, anyways the `Cur` is checked right below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95158/new/
https://reviews.llvm.org/D95158
More information about the llvm-commits
mailing list