[PATCH] D95219: [libObject,llvm-readelf/obj] - Don't use @@ when printing versions of undefined symbols.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

As noted elsewhere, I'm not really familiar with symbol versioning, so it would be better if @MaskRay looked at this.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:773-775
+  Expected<StringRef> VerOrErr = Obj.getSymbolVersionByIndex(
+      Version, IsDefault, **MapOrErr, Sym.st_shndx == ELF::SHN_UNDEF);
+  return VerOrErr;
----------------
Why not return directly as it did before?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95219/new/

https://reviews.llvm.org/D95219