[PATCH] D92282: [VPlan] Handle scalarized values in VPTransformState.

Gil Rapaport via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 24 23:47:47 PST 2021


gilr requested changes to this revision.
gilr added a comment.
This revision now requires changes to proceed.

LGTM, with a nit. Thanks!



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:233
+  if (hasVectorValue(Def, Instance.Part)) {
+    assert(Data.PerPartOutput.count(Def));
     auto *VecPart = Data.PerPartOutput[Def][Instance.Part];
----------------
The assert is missing an "error message", but checking hasVectorValue() seems a bit too defensive. Any reason to assert here? (and not assert at line 230?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92282/new/

https://reviews.llvm.org/D92282



More information about the llvm-commits mailing list