[PATCH] D88391: [M68k] (Patch 5/8) Target lowering

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kInstrInfo.h:64
+  default:
+    llvm_unreachable("Illegal condition code!");
+  case M68k::COND_T:
----------------
RKSimon wrote:
> (style) Remove default case and move llvm_unreachable after the switch statement
strange...GCC 9 will still pop up warning (about cases not handled) after I move llvm_unreachable after the switch statement


================
Comment at: llvm/lib/Target/M68k/M68kInstrInfo.h:103
+  default:
+    llvm_unreachable("Illegal condition code!");
+  case M68k::COND_EQ:
----------------
RKSimon wrote:
> (style) Remove default case and move llvm_unreachable after the switch statement
ditto the same warning


================
Comment at: llvm/lib/Target/M68k/M68kMCInstLower.cpp:119
+    LLVM_DEBUG(MI->dump());
+    llvm_unreachable("unknown operand type");
+  case MachineOperand::MO_Register:
----------------
RKSimon wrote:
> (style) Move this after the switch statement
GCC 9 popped out warnings about unhandled cases after moving llvm_unreachable after the switch statement


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88391/new/

https://reviews.llvm.org/D88391