[PATCH] D88390: [M68k] (Patch 4/8) MC layer and object file support

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCAsmInfo.cpp:29
+  // Filled with NOP (0b0100_1110_0111_0001)
+  TextAlignFillValue = 0x4e71;
+
----------------
jrtc27 wrote:
> This doesn't work; it's assumed to be a single byte (MCAsmStreamer passes ValueSize as 1 when using it), but if it did it would presumably need to be dealt with very carefully wrt endianness.
good catch, and you're right non-single byte fill value will never be used. I'll just remove this line to let MC use the default value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88390/new/

https://reviews.llvm.org/D88390