[PATCH] D88390: [M68k] (Patch 4/8) MC layer and object file support

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kBaseInfo.h:116
+
+// enum {
+//   //===------------------------------------------------------------------===//
----------------
Commented-out code.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCAsmInfo.cpp:29
+  // Filled with NOP (0b0100_1110_0111_0001)
+  TextAlignFillValue = 0x4e71;
+
----------------
This doesn't work; it's assumed to be a single byte (MCAsmStreamer passes ValueSize as 1 when using it), but if it did it would presumably need to be dealt with very carefully wrt endianness.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp:205
+  auto MIOpIdx = M68k::getLogicalOperandIdx(MI.getOpcode(), Op);
+  bool isPCRel = Desc.OpInfo[MIOpIdx].OperandType == MCOI::OPERAND_PCREL;
+
----------------
Capitalise


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp:281
+  } else {
+    // assert (!Alt && "You cannot use Alt immediate with a simple operand");
+    MCO = MI.getOperand(MIOpIdx);
----------------
?


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCTargetDesc.cpp:80
+  // Calculate amount of bytes used for return address storing
+  int stackGrowth = -4;
+
----------------
Capitalise


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88390/new/

https://reviews.llvm.org/D88390